Open ymgan opened 1 year ago
I think it is worth mentioning that depth should not be negative: https://github.com/tdwg/bdq/issues/107#issuecomment-961330986
Maybe we should take this into consideration while considering the parameters minimumValidDepthInMeters~
I think it also means adding support for minimumDistanceAboveSurface
and maximumDistanceAboveSurface
?
I think it also means adding support for
minimumDistanceAboveSurface
andmaximumDistanceAboveSurface
?
@albenson-usgs I don't know. I am just mapping the obis-qc checks to checks in BDQ and GBIF. I leave the other tests relevant for the fields here since I had to go through them.
Unless OBIS indicates the capacity to implement the checks for minimumDistanceAboveSurface
and maximumDistanceAboveSurface
, I will not look at that (no funding haha) I am doing this outside office hours. Anyone else is welcome to look at that though.
@albenson-usgs Are there any existing BDQ checks that take into account minimumDistanceAboveSurface
and maximumDistanceAboveSurface
?
I do think we'll need to take these into account when deriving depth values, if I understand correctly a min/maximumDepthInMeters
of 100 (which then becomes the reference surface) and a min/maximumDistanceAboveSurface
of 10 should result in a derived depth value of 90 (for filtering purposes etc).
Thanks @pieterprovoost! There isn't any test for minimumDistanceAboveSurfaceInMeters
and maximumDistanceAboveSurfaceInMeters
from BDQ. There are only tests for depth and elevations.
I don't see any test for min/maximumDistanceAboveSurfaceInMeters
in GBIF either.
2023-04-20 meeting
obis-qc checks
TDWG BDQ TG2 Tests
Validation
*Parameterized
Amendment
Parameters
GBIF flags
https://github.com/gbif/gbif-api/blob/dev/src/main/java/org/gbif/api/vocabulary/OccurrenceIssue.java
Visualization for OBIS data
Notebook here
enddepth <= 0
verbatimDepth, based on facet API
https://api.obis.org/v3/facet?facets=verbatimDepth
Related issues