search

iobis / obis-qc

OBIS QC checks
10 stars 4 forks source link

coordinateUncertaintyInMeters valid range should be >0 #36

Closed ymgan closed 1 year ago

ymgan commented 1 year ago

https://github.com/iobis/obis-qc/blob/37c0a0a9f8e51c0c8dbff0d86769475c3f475fbf/obisqc/location.py#L17C33-L17C33

Because check_float uses <=, the minimum value for valid range should be 1 and not 0

Reasoning of why it should not be <1, please see this comment which I agree

pieterprovoost commented 1 year ago

Valid range adjusted to correspond to BDQ.