Closed ayushanand18 closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
This PR is in succession to #97
This PR is in succession to #97
I think this PR's branch may need to be rebased from the new main
to avoid merge conflicts related to the way this was chained with #97
I think this PR's branch may need to be rebased from the new
main
to avoid merge conflicts related to the way this was chained with #97
I did a rebase
after the merge.
Indeed, git rebase
is a powerful tool to avoid merge conflicts and code leakages during collaborations. Thank you for teaching me one of the most powerful weapons I have now :)
Overview
This PR aims to enable array handling for
taxonid
as well. Adding support for querying multipletaxonid
s at the same time will be crucial as well as beneficial for the package.Method
obisutils.py
file to handle integer arrays. Sincetaxonid
s are integer values, therefore we could not fit them into the existing array handling function for strings -handle_arrstr()
.handle_arrstr()
would lead to unnecessary type conversion attempts and missed type checks fortaxonid
items.handle_arrint()
function.Tries to resolve #99.
Thanks!