iobis / pyobis

OBIS Python client
https://iobis.github.io/pyobis
MIT License
15 stars 10 forks source link

Publish docs only for releases and update GHA #118

Closed ocefpaf closed 1 year ago

ocefpaf commented 1 year ago

Alternative for #117 and fixes #116.

ayushanand18 commented 1 year ago

Thank you so much @ocefpaf! But we would like to fast-forward to 1.3.0, I understand that whenever we publish the docs, the version gets incremented from the current version but how do we fast forward it to 1.3.0 or define if we have a major/minor/patch update and increment the version accordingly?

ocefpaf commented 1 year ago

Thank you so much @ocefpaf! But we would like to fast-forward to 1.3.0, I understand that whenever we publish the docs, the version gets incremented from the current version but how do we fast forward it to 1.3.0 or define if we have a major/minor/patch update and increment the version accordingly?

All we need to do is to tag it 1.3.0. When this is ready, tag it and it will propagate everywhere. The "dirty" git dev tag doesn't increment much b/c it only know that it is different from the last tagged versions. Also, we don't really care about the dirty dev one that much, it is only used do ensure we know the git commit used when debugging it.

ayushanand18 commented 1 year ago

All we need to do is to tag it 1.3.0. When this is ready, tag it and it will propagate everywhere. The "dirty" git dev tag doesn't increment much b/c it only know that it is different from the last tagged versions. Also, we don't really care about the dirty dev one that much, it is only used do ensure we know the git commit used when debugging it.

I got it, thanks! This is some amazing engineering that will take some iterations for me to completely understand 👀

MathewBiddle commented 1 year ago

Something of interest. A conda search pyobis returns the two different versions, but it looks like the builds are the same? That's probably okay and something I need to learn about?

>conda search pyobis
Loading channels: done
# Name                       Version           Build  Channel             
pyobis                         1.2.6    pyhd8ed1ab_0  conda-forge         
pyobis                         1.3.0    pyhd8ed1ab_0  conda-forge    
ocefpaf commented 1 year ago

but it looks like the builds are the same?

That is either a bug in conda-build or a super coincidence! The build hash should be unique to each build, even of the same version when we change things. With that said, it is not a big deal. I checked the code and the versions are different and the right ones.

7yl4r commented 1 year ago

super coincidence

a super duper extra rare crazy unlikely miracle coincidence