search

iobis / pyobis

OBIS Python client
https://iobis.github.io/pyobis
MIT License
14 stars 10 forks source link

adds `pytest-vcr` to tests #124

Closed ayushanand18 closed 1 year ago

ayushanand18 commented 1 year ago

Overview

As per discussion in #120, this PR adds pytest-vcr and recorded cassettes of network interaction while running tests.

Changes Introduced

  1. Marks all tests with vcr so that all network interactions are recorded.
  2. The recorded cassettes are also committed.
  3. Adds pytest-vcr as a dev dependency.
  4. Adds flag to not record while executing GitHub Actions workflow.

Thanks!

ayushanand18 commented 1 year ago

I had an opportunity to relook the workflow file for tests, and I figured out that we are testing this package on a bunch of python versions. I believe any three versions could be good.

We can keep the last two versions and a third could be an old version (say 3.7) to checkout for breaking changes.

ayushanand18 commented 1 year ago

@ocefpaf waiting for your feedback on this :)

ocefpaf commented 1 year ago

@ocefpaf waiting for your feedback on this :)

Apologies. I'll review it right now!

ayushanand18 commented 1 year ago

Apologies. I'll review it right now!

No issues. I just thought you forgot to add a review.

ocefpaf commented 1 year ago

All green! I don't want to merge this b/c there are some commits I added later to fix the CIs, so a third party review would be nice.

Thanks @ayushanand18!

ayushanand18 commented 1 year ago

All green! I don't want to merge this b/c there are some commits I added later to fix the CIs, so a third party review would be nice.

Thank you so much! The best thing I like about PRs is I get to learn a lot from code reviews. I worked at a place for some days where code reviews weren't a serious thing and I felt really terrible - this is the reason I love open source ♥️.

I think @7yl4r is the best person to merge this.