search

iobis / pyobis

OBIS Python client
https://iobis.github.io/pyobis
MIT License
14 stars 10 forks source link

Fix links #147

Closed ocefpaf closed 3 months ago

ocefpaf commented 3 months ago

Should help fix the link-checker failure in #146.

@ayushanand18 I'm not sure if you are the one that created the bit.ly link but can you try to help me sort this out? The link seems to redirect to an http page that doesn't seem correct to me. Also, it is broken in #146. Last but not least, I'd rather have the full link and skip code style there than have the info obfuscated by a URL shortener.

In this PR I added the full URL and the lint skips but I need some help to check if that URL is actually the one the authors of the docstrings added there originally.

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

ayushanand18 commented 3 months ago

I'm very sorry for overlooking this, but it's most probably a tech debt (or what should I call it) carried forward from pygbif -> pyobis when original authors copied configs while creating the latter.

ocefpaf commented 3 months ago

I'm very sorry for overlooking this, but it's most probably a tech debt (or what should I call it) carried forward from pygbif -> pyobis when original authors copied configs while creating the latter.

Not your fault. That is why we run tests ;-p

Thanks for the working URL. I'll update it accordingly.

ayushanand18 commented 3 months ago

I hope this is ready to merge? just mentioning @ocefpaf for you to merge it whenever it's ready.

PS. Just to make sure we are not waiting for me.

ocefpaf commented 3 months ago

I hope this is ready to merge? just mentioning @ocefpaf for you to merge it whenever it's ready.

👍🏽

PS. Just to make sure we are not waiting for me.

I was but NP. I try to avoid self-merges as much as I can. Thanks for the review and for the fix!