Resolving #30, #31, and #32: Modifying occurrence.search() to resolve unexpected results

ayushanand18 commented 2 years ago

Overview

This PR aims to resolve #30, #31, and #32.

Since all these issues demanded only minor yet impactful change to the same occurrence.search() function, I am combining them into one single PR. Changes in brief:

Added a looping construct with a default 5000 iterations per page to fetch occurrence records.
Added a null-check condition when accessing mof records to ensure it doesn't throw an error in case of occurrence records are not found for a given species.
Resolved the duplicate column issue when fetching MoF records

Notes for Reviewers

While the latter two objectives are important but less significant than the first objective.

Next Steps

I will now be completing the WiP occurrence_ocean_sunfish.ipynb.

ayushanand18 commented 2 years ago

The tests are failing due to the change introduced in MoF response. I am working to resolve it.

ayushanand18 commented 2 years ago

Update: I updated the test-occurrence.py file and modified tests pertaining to fetching mof records. Now the tests are passing.

iobis / pyobis