search

iobis / pyobis

OBIS Python client
https://iobis.github.io/pyobis
MIT License
15 stars 10 forks source link

publish to PyPI #44

Closed ocefpaf closed 2 years ago

ocefpaf commented 2 years ago

@sckott can you grant @7yl4r and myself PyPI maintainer status for this package? This PR will automate the releases based on GH actions but we need set set the token and be able to yank releases if necessary.

@7yl4r We can merge this one but we can only issue releases after we add the token to this repo.

7yl4r commented 2 years ago

@ocefpaf : what should we do if we don't hear from @sckott

ocefpaf commented 2 years ago

@ocefpaf : what should we do if we don't hear from @sckott

Ideally we should keep the project here. If we don't hear from him we can move it to the IOOS org where we would have the right permissions. But I'd like to avoid that if we can. (And use a different name for PyPI :-/)

sckott commented 2 years ago

working on it

sckott commented 2 years ago

@ocefpaf you should be getting an invitation email from pypi.

@7yl4r what's your pypi username?

7yl4r commented 2 years ago

It's 7yl4r. I just set it up. Thanks!

sckott commented 2 years ago

invitiatoin sent

ocefpaf commented 2 years ago

Thanks @sckott!

ocefpaf commented 2 years ago

@7yl4r this PR is ready to go. The last step is to add the PyPI token to this repository secrets. We will need someone with elevated rights here to do so. Maybe @pieterprovoost can help us out?

pieterprovoost commented 2 years ago

@ocefpaf @7yl4r Added PYPI_API_TOKEN, can you please check?

ocefpaf commented 2 years ago

@ocefpaf @7yl4r Added PYPI_API_TOKEN, can you please check?

B/c we cannot access the token config the only way for us to check is to mind a new release. @ayushanand18 and @7yl4r do you believe we are ready for one?

pieterprovoost commented 2 years ago

Sorry about that, I have bumped your privileges.

7yl4r commented 2 years ago

I see the secret; looks good. I just created a release, but it appears the github action did not trigger. Should we be using on:release [ref] instead of using if: ${{github.event_name == 'release'}}?

ocefpaf commented 2 years ago

That if-clause works on my projects but is is worth testing on release only. I use it that way b/c we run on PRs are a tarball test and then on release to publish.