search

iobis / pyobis

OBIS Python client
https://iobis.github.io/pyobis
MIT License
15 stars 10 forks source link

Fix `on` in workflow #48

Closed ayushanand18 closed 2 years ago

ayushanand18 commented 2 years ago

Overview

This PR aims to fix on call branches arguments. It expects a string but a list was given.

Screenshot of the error

image

Solution

Changing

on:
   push:
        branches:
        - [master,main]

to

on:
   push:
        branches:
        - master
        - main

This was causing the workflow to fail without even starting, making it difficult to understand the exact cause for failure or whether it would even fail when run.

Notes for reviewers

You can merge this PR or amend the workflow file and dump this one.

ocefpaf commented 2 years ago

I believe the first one is also valid yam list, may we missed an indentation or something.