iobis / pyobis

OBIS Python client
https://iobis.github.io/pyobis
MIT License
14 stars 10 forks source link

obisissues.py is unused? #72

Closed 7yl4r closed 2 years ago

7yl4r commented 2 years ago

obisissues is a module which is essentially just a lookup table for error codes coming from the API. I don't think we are using this, and I am also uncertain if this module is up-to-date. We could remove the module, but we may also want to retain it for future use. Some text noting this at the top of the file might be sufficient, or we could keep it in a separate branch. I am not sure what is the best practice for retaining legacy code.

7yl4r commented 2 years ago

@ayushanand18 tested some of this and found that the error codes are out of date. The current OBIS API error codes are more self-explanitory.

This file was adapted from pyGBIF, and may never have been valid for the OBIS API.

With this in mind I am deleting the file and closing this issue. Here is a reference to the file if needed in the future: https://github.com/iobis/pyobis/blob/d0aa1a5996dcea57d414592300ed6eef08561b5e/pyobis/obisissues.py