search

iobroker-community-adapters / ioBroker.accuweather

Accuweather forecast
MIT License
6 stars 9 forks source link

Limit requests to 50 a day #114

Closed stevoboy closed 3 years ago

stevoboy commented 3 years ago

Describe the bug
The Adapter makes more than 3000 requests even though 50 is offered in free trail. There is no option to set the frequency of get requests.

To Reproduce
Steps to reproduce the behavior: Install accuweather Adapter and register at the webpage. Set up the adaptor with the keys Expected behavior
Option to determine the frequency of get update requests to accuweather api

algar42 commented 3 years ago

Adapter automatically makes only 29 requests per day as described in readme. How did you get 3000? There is no reason to limit the number of requests - someone may have payed access to API.

stevoboy commented 3 years ago

Adapter automatically makes only 29 requests per day as described in readme. How did you get 3000? There is no reason to limit the number of requests - someone may have payed access to API.

I contacted customer support of accuweather an got this reply: image

I check the protocol and the adapter throws thousands of errors - to me it looks like it is executing the get request more than 29 requests per day.... even if not in error mode: image

Is there no possibility in the adapter to define how many requests to issue per day and what to do in case of error?

algar42 commented 3 years ago

It works for many people (including me) without reaching 50 requests per day. You can reach 50 if you manually request forecast updates by using the following adapter states: image Or you can reach the limit if the adapter restarts more than 21 times per day, since it makes single request at start.

I have no other ideas of how else it could possible to make such a big number of requests to their server. Please check your system first... something is definitely wrong, but not sure that it is the adapter issue.

How often do you get '503 unauthorized' messages in your log? Per the picture above I see two with 1 microsecond difference in timestamp.. it should be one message per hour only.

stevoboy commented 3 years ago

The problem is solved. It was my fault - I had Accuweather restart every hours as I was used to from the openweathermap adapter. This lead to a higher number of call requests than necessary. The Accuweather adapter is now working stable. Thank you very much for your help!