iobroker-community-adapters / ioBroker.broadlink2

ioBroker adapter for broadlink devices like the RM remote or SP switches

MIT License

41 stars 15 forks source link

Fixes for Issues reported by Repository checker [#350] #351

Closed mattreim closed 3 days ago

mattreim commented 1 month ago

362

mcm1957 commented 1 month ago

@mattreim Are you sure that words.js is NOT used by any code part? Might be access from runtime code too - not only from (removed) admin html code. Did you check this?

If deleted adaptions at weblate config are required. Whover merges this PR please consider this and contact me.

mattreim commented 1 month ago

You're right. I can't check it properly so I restored it.

mcm1957 commented 5 days ago

@mattreim Did you Test compact mode? Simply enabling it is not the goal.

mattreim commented 5 days ago

Actually it should work with admin5.

mattreim commented 5 days ago

I'll delete it again.

mcm1957 commented 5 days ago

Actually it should work with admin5.

Ähhmm I do not see any reaktion between ADMIN and compact mode. Did you mean js-controller 5?

But there might be a timer which is not cancelled at unload. Thats incompatible with compact mode.

mattreim commented 5 days ago

Anything can happen with this old adapter.