iobroker-community-adapters / ioBroker.chromecast

ioBroker Chromecast Adapter
MIT License
22 stars 12 forks source link

wrong data in ...metadata.title field #26

Closed etv99 closed 3 years ago

etv99 commented 6 years ago

Since the rewrite to 1.2.x the field contains always the station name when playing webradio instead of the real title of the song.....

thanks tom

angelnu commented 6 years ago

From what I can tell reviewing the code the title should be detected as before... So I would need to check the ICY data from the radio stream you are using.

Could you please provide the URL of the webradio you are testing?

etv99 commented 6 years ago

Good Morning,

it's on all stations we hear - and was OK with all stations until version 1.2.

Here are all stations:

Thanks tom

Am 29.01.2018 23:47 schrieb "Vegetto" notifications@github.com:

From what I can tell reviewing the code the title should be detected as before... So I would need to check the ICY data from the radio stream you are using.

Could you please provide the URL of the webradio you are testing?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/angelnu/ioBroker.chromecast/issues/26#issuecomment-361413648, or mute the thread https://github.com/notifications/unsubscribe-auth/AiQiwsDq0uurZT7n_Dqei39RpQHIBjWGks5tPkptgaJpZM4RwidI .

angelnu commented 6 years ago

I can confirm that I get the original metadata header but afterwards we should be getting aditional metadata for the title. This will require more investigation...

This the code to intercept the title metadata in the cast2-player node.js module:

// log any "metadata" events that happen                                                                       
        res.on('metadata', that._gotMetadata.bind(that, res));

And this the metadata header:

{ 'content-type': 'audio/mpeg',
--
date: 'Tue, 30 Jan 2018 22:17:38 GMT',
'icy-br': '128, 128',
'ice-audio-info': 'ice-samplerate=44100;ice-bitrate=128;ice-channels=2',
'icy-description': 'Immer einen Hit voraus',
'icy-genre': 'Top40',
'icy-name': 'Antenne Steiermark',
'icy-pub': '1',
'icy-url': 'http://www.antenne.at',
server: 'Icecast 2.4.0-kh7',
'cache-control': 'no-cache, no-store',
'access-control-allow-origin': '*',
'access-control-allow-headers': 'Origin, Accept, X-Requested-With, Content-Type',
'access-control-allow-methods': 'GET, OPTIONS, HEAD',
connection: 'Close',
expires: 'Mon, 26 Jul 1997 05:00:00 GMT',
'icy-metaint': '16000' }
etv99 commented 6 years ago

Hi,

OK, I will try to look for this Part of Code also in the old version....

Thanks Tom

Am 30.01.2018 23:58 schrieb "Vegetto" notifications@github.com:

I can confirm that I get the original metadata header but afterwards we should be getting aditional metadata for the title. This will require more investigation...

This the code to intercept the title metadata in the cast2-player node.js module:

// log any "metadata" events that happen res.on('metadata', that._gotMetadata.bind(that, res));

And this the metadata header:

{ 'content-type': 'audio/mpeg',

date: 'Tue, 30 Jan 2018 22:17:38 GMT', 'icy-br': '128, 128', 'ice-audio-info': 'ice-samplerate=44100;ice-bitrate=128;ice-channels=2', 'icy-description': 'Immer einen Hit voraus', 'icy-genre': 'Top40', 'icy-name': 'Antenne Steiermark', 'icy-pub': '1', 'icy-url': 'http://www.antenne.at', server: 'Icecast 2.4.0-kh7', 'cache-control': 'no-cache, no-store', 'access-control-allow-origin': '*', 'access-control-allow-headers': 'Origin, Accept, X-Requested-With, Content-Type', 'access-control-allow-methods': 'GET, OPTIONS, HEAD', connection: 'Close', expires: 'Mon, 26 Jul 1997 05:00:00 GMT', 'icy-metaint': '16000' }

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/angelnu/ioBroker.chromecast/issues/26#issuecomment-361763582, or mute the thread https://github.com/notifications/unsubscribe-auth/AiQiwn03cbnIKqSfuH_bOMT4Rc2fGR5Eks5tP56VgaJpZM4RwidI .

angelnu commented 6 years ago

@etv99 - did you try with the old version?

etv99 commented 6 years ago

hi, no sorry there was no time for me the last months....maybe in the "summer hole" 😁

Vegetto notifications@github.com schrieb am Di., 3. Apr. 2018, 04:05:

@etv99 https://github.com/etv99 - did you try with the old version?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/angelnu/ioBroker.chromecast/issues/26#issuecomment-378104480, or mute the thread https://github.com/notifications/unsubscribe-auth/AiQiwgDvao3eHJuvJJxV5qemnb96RO1Lks5tktj0gaJpZM4RwidI .

etv99 commented 4 years ago

Hi @angelnu,

long time ago I gave this problem a new try and was searchig for the reason why no data is received....

Since my programming know how is very low, I first tried to see, which parts of the program are "running".

So I put some lines "log.info" in the code of castv2-player to see where the programm is going around....

But I don't get the log output with this line in iobroker log.info("etv LOGGING - let parser - line 150");

How do I generate some Log Outputs from this scripts?

It's definitely that vastv2-player doesn't return the right values...

thanks tom

Jey-Cee commented 3 years ago

Seems this works in version 2.3.1. So i close this issue.