iQontrolHomematicIpThermostat doesn't set the control mode correctly

tehXor commented 2 years ago

Describe the bug
Switching from manual to automatic control mode does not work.

To Reproduce
With a HmIP-WTH-2 which has the role iQontrolHomematicIpThermostat:

Go to extended dialog
Switch from the default automatic mode to manual (which works)
Switch from manual mode back to automatic (this does not work and it also tries to trigger boost)

Expected behavior
Switching back to manual mode should work.

Screenshots & Logfiles
n/a

Versions:

Adapter version: 2.0.0
Chrome: 105

Workaround In index.js change: Line 9784

var value = $("input[name='DialogThermostatControlModeCheckboxradio']:checked").val();

to

var value = parseInt($("input[name='DialogThermostatControlModeCheckboxradio']:checked").val());

and

Line 9799

var setValue = setValues[index] || true;

to

var setValue = setValues[index]
if (setValue === undefined) setValue = true

(Not sure if the workaround covers all cases, I just tried for my specific case which does not include boost for example.)

sbormann commented 2 years ago

Hi, I am currently working on this - sorry for the long delay. Could you please send me the RAW of CONTROL_MODE? I have no HM-IP-Thermostat so it is difficult for me to figure out the problem. Many thanks!

tehXor commented 2 years ago

Hi, I am currently working on this - sorry for the long delay.

Thanks and no worries. My workaround is doing fine and if I don't have to maintain it at some point in future since you fix it upstream, too I'm already more than happy. You're project is so very functional and time saving for building web app interfaces that even living with some of those bugs long term would still be no problem. So thanks a lot for your work :)

Could you please send me the RAW of CONTROL_MODE?

Anyways, I hardly have any experience with ioBroker and HM devices yet so I'm not exactly sure what you mean with RAW... Regarding the workaround I just had a quick look at the dev tools and saw that at https://github.com/sbormann/ioBroker.iqontrol/blob/e2afa70e0ca0bed7b7167867d08681edf6810ad9/www/index.js#L9784 a string was returned while I assumed an integer is what we actually wanted. So I added the parseInt here also I'm not entirely sure if it would have been required. And than what ultimately caused the problem in my case was that at https://github.com/sbormann/ioBroker.iqontrol/blob/e2afa70e0ca0bed7b7167867d08681edf6810ad9/www/index.js#L9799
setValue will fall back to true in case setValues[index] is 0 and that is the case for AUTO-MODE. This is why I changed it like described in my first post.

And here is the ioBroker object data for CONTROL_MODE in case that helps. But if you need more, just tell me where to find it and I'll post it!

{
  "type": "state",
  "common": {
    "name": "CONTROL_MODE",
    "role": "indicator",
    "def": 0,
    "type": "number",
    "read": false,
    "write": true,
    "min": 0,
    "max": 3
  },
  "native": {
    "MIN": 0,
    "OPERATIONS": 2,
    "MAX": 3,
    "FLAGS": 1,
    "ID": "CONTROL_MODE",
    "TYPE": "INTEGER",
    "DEFAULT": 0,
    "CONTROL": "HEATING_CONTROL_HMIP.CONTROL_MODE"
  },
  "from": "system.adapter.hm-rpc.0",
  "user": "system.user.admin",
  "ts": 1663187584916,
  "_id": "hm-rpc.0.000A9FXXXXXXXX.1.CONTROL_MODE",
  "acl": {
    "object": 1636,
    "state": 1636,
    "owner": "system.user.admin",
    "ownerGroup": "system.group.user"
  }
}

sbormann commented 2 years ago

Would it be possible for me to connect to your system (via Anydesk or RustDesk) and see what exactly happens when you change modes? Maybe next weekend?