Closed basti4557 closed 9 months ago
@basti4557 Thanks very much for the extrem fast response.
Looks good to me except one question / feedback:
change at line 589 (new) from
if (!inp) {
//
} else if (inp.indexOf('hdmi') == 0) {
to
if (inp.indexOf('hdmi') == 0){
could result in an exception if inp is null / undefined if I'm correct. Or can you ensure, that inp is always valid? Wouldn't
if (inp && (inp.indexOf('hdmi') == 0)){
be more save? Please comment or change if you think that chacking inp itself too is better.
In addition please answer my question from yesterday wether wss (encrypted) communication is available at all LGTVs. Otherwise this change could be block some devices.
Thanks Martin (mcm1957)
P.S. Do you now if your changes fix one or more of the xisting issues? Please list them in an comment so that I can close them with reference to new upcoming version
Hi
if (inp && (inp.indexOf('hdmi') == 0))
I also think this is better.
The following forks have been used: https://github.com/setfire2/ioBroker.lgtvs - Websocket to SSL Connection https://github.com/foxriver76/ioBroker.lgtv - Get ready for js-controller v5
The last changes in sendPackage & checkCurApp were in my repository basti4557/iobroker.lgtvs. To open this pull request i had to delete it because i forked from setfire2/iobroker.lgtvs
If all old TVs are supporting this SSL Websocket i cant say. Some persons used my iobroker.lgtvs fork quite a time and no one got any problems with this changes.
Issues should be:
But ofc someone should test my fork on a actual iobroker instance because its not 1:1 the same code anymore than from setfire2/iobroker.lgtvs
Greetings basti
I'll fix the two minor linter issues during release build @basti4557 THANKS VERY VERY MUCH for you support and work
I synced all done changes here necessarry for using this adapter.