iobroker-community-adapters / ioBroker.lgtv

LG WebOS SmartTV adapter for ioBroker
http://iobroker.net/
MIT License
22 stars 21 forks source link

V2.1.0 - keepaliveInterval must be specified.. #161

Closed Ilovegym66 closed 9 months ago

Ilovegym66 commented 9 months ago

js-controller 5.0.12, Node 18.17.0, Bookworm LXC. Beim starten folgendes:

` 2023-10-05 11:24:32.680 - info: host.iobrokerS2 instance system.adapter.lgtv.1 started with pid 178116 2023-10-05 11:24:33.783 - info: lgtv.1 (178116) starting. Version 2.1.0 (non-npm: iobroker-community-adapters/ioBroker.lgtv) in /opt/iobroker/node_modules/iobroker.lgtv, node: v18.17.0, js-controller: 5.0.12 2023-10-05 11:24:33.803 - info: lgtv.1 (178116) Ready. Configured WebOS TV IP: 10.1.1.31 2023-10-05 11:24:33.998 - error: lgtv.1 (178116) uncaught exception: keepaliveInterval must be specified and numeric if keepalive is true. 2023-10-05 11:24:33.998 - error: lgtv.1 (178116) Error: keepaliveInterval must be specified and numeric if keepalive is true. at new WebSocketConnection (/opt/iobroker/node_modules/websocket/lib/WebSocketConnection.js:113:19) at WebSocketClient.succeedHandshake (/opt/iobroker/node_modules/websocket/lib/WebSocketClient.js:343:22) at WebSocketClient.validateHandshake (/opt/iobroker/node_modules/websocket/lib/WebSocketClient.js:332:10) at ClientRequest.handleRequestUpgrade (/opt/iobroker/node_modules/websocket/lib/WebSocketClient.js:261:14) at ClientRequest.emit (node:events:514:28) at TLSSocket.socketOnData (node:_http_client:581:11) at TLSSocket.emit (node:events:514:28) at addChunk (node:internal/streams/readable:324:12) at readableAddChunk (node:internal/streams/readable:297:9) at Readable.push (node:internal/streams/readable:234:10) 2023-10-05 11:24:33.999 - error: lgtv.1 (178116) keepaliveInterval must be specified and numeric if keepalive is true. 2023-10-05 11:24:34.002 - info: notification-manager.0 (2177) New notification on "iobrokerS2" detected 2023-10-05 11:24:34.002 - info: lgtv.1 (178116) terminating 2023-10-05 11:24:34.002 - warn: lgtv.1 (178116) Terminated (UNCAUGHT_EXCEPTION): Without reason 2023-10-05 11:24:34.502 - info: lgtv.1 (178116) terminating 2023-10-05 11:24:34.534 - error: host.iobrokerS2 instance system.adapter.lgtv.1 terminated with code 6 (UNCAUGHT_EXCEPTION) 2023-10-05 11:24:34.534 - info: host.iobrokerS2 Restart adapter system.adapter.lgtv.1 because enabled 2023-10-05 11:24:40.595 - info: javascript.0 (612) script.js.common.Nuki.mqtt2log: NUKI Hub WT: Querying lock state: unlocked 2023-10-05 11:24:44.355 - info: mqtt.1 (666) Client [Presence1221] connected with secret 1696497884273_8039 2023-10-05 11:24:54.636 - info: host.iobrokerS2 "system.adapter.lgtv.1" disabled 2023-10-05 11:24:56.599 - info: host.iobrokerS2 "system.adapter.lgtvs.1" enabled 2023-10-05 11:24:56.612 - info: host.iobrokerS2 instance system.adapter.lgtvs.1 started with pid 178496

`

Ilovegym66 commented 9 months ago

image

mcm1957 commented 9 months ago

@basti4557 Could you please check and fix ?

basti4557 commented 9 months ago

I am going to fix it today evening, i already know the problem.

mcm1957 commented 9 months ago

Thanks - I stopped 2.1.0 from beeing published at latest (at least I hope so :-) )

Smallfeuer commented 9 months ago

Hello, short Feedback, my OLED48A29LA with Software 03.33.60 --> Adapter 1.12 = red = no reaction with Adapter 2.1.0 --> red = turn on is possible, but i can not turn off the tv

OLED65C97LA --> Adapter 1.12 = green = on, off possible, switch channel etc. Adapter 2.1.0 --> red - no connection

hope you can fix it :)

basti4557 commented 9 months ago

@Ilovegym66 could you please test https://github.com/basti4557/ioBroker.lgtv ? Im correcting it blind atm because i have no iobroker instance nearby.

If it works il open an PR

Ilovegym66 commented 9 months ago

Thanks, issue solved, works like expected and like your lgtvs adapter before.. :-) Tested with 86UN85006LA and 55UP76709LB.

Smallfeuer commented 9 months ago

Also worked for my OLED48A29LA & OLED65C97LA :) Thanks @basti4557 👍

mcm1957 commented 9 months ago

Keep open until merged in relese

mcm1957 commented 9 months ago

fixed with 2.1.1-alpha.0

mcm1957 commented 9 months ago

@Ilovegym66 Ich hab den Fix von @basti4557 (DANKE für die rasche Reaktion) nun gemerged und eine v2.1.1-alpha.0 erstellt. Diese ist NUR via github und npm installierbar. Bitte diese - wenn nicht zu viel Arbeit - installieren und Bescheid geben ob sie ok ist. Dann release ich diesen Softwarestand morgen bzw. nach Rückmeldung als 2.1.1 ins Latest zum allgemeinen Test

basti4557 commented 9 months ago

I also tested for the first time my repo changes. Seems that the blind changes work fine.

Remote Keys / Channel Up / Down, currentApp State Subscription, TV On/Off tested on OLED55CS9LA.

Ilovegym66 commented 9 months ago

fix is working fine. No issues any more with 2.1.1.a0. thank you! Tested with 86UN85006LA and 55UP76709LB.