search

iobroker-community-adapters / ioBroker.lgtv

LG WebOS SmartTV adapter for ioBroker
http://iobroker.net/
MIT License
22 stars 21 forks source link

states.on does not change when turned off #165

Closed instalator closed 8 months ago

instalator commented 9 months ago

After turning off the TV, the status does not change and remains true. currentApp also does not change after shutdown.

mcm1957 commented 9 months ago

@instalator

Just to make clear: You refer to turnig off the TV using the adapter or to turning off the tv using tv-remote/directly at the tv

Or do you refre to the same problem describer as #164

instalator commented 9 months ago

@instalator

Just to make clear: You refer to turnig off the TV using the adapter or to turning off the tv using tv-remote/directly at the tv

Or do you refre to the same problem describer as #164

Using an adapter.

v1.1.12 Works correctly

agross commented 9 months ago

You refer to turnig off the TV using the adapter or to turning off the tv using tv-remote/directly at the tv

Turning off the TV using the TV remote also does not change states.on to false. At least not immediately like it used to be. It takes about 5-10 minutes for the adapter to detect such a turned-off TV.

agross commented 9 months ago

I also do not understand why 4c4d4fd864a4 (part of the 2.x release) reverts the code from 03c93c7810b6. There is a reason why 03c93c7810b6 was added by me: #80

mcm1957 commented 9 months ago

@agross

As stated at 2.0.0 releasenotes: POSSIBLE BREAKING: Adapter has been built from current github content. As latest npm packages have been created external, theres a chance that some changes got lost.

The adpater was no longer maintained by original maintainer. There was a difference betwenn the npm release and the github release and nobody knew for sure what was the latest / best code base. So 2.0.0 was taken from github and fixes required to make the adapter working with newer devises at parallel forks have been merged.

So sad to say improvments by you seem to have been lost.

As stated at several occasions I cannot debug the code as I do nozt have a matching device.

So if you would be so kind to remerge you code changes to make on/off work as intended and provide a PR I will be glad zu merge it into a new release and publish it at latest for broader tests. Thanks in advance.

mcm1957

P.S: Can you check if ttps://github.com/iobroker-community-adapters/ioBroker.lgtv/issues/164 has the same reason / is a duplicate to this issue?

mcm1957 commented 9 months ago

@instalator @agross Please retest with 2.1.2 (available at latest tomorrow)

instalator commented 8 months ago

Please retest with 2.1.2 (available at latest tomorrow)

Now works. Thank you!

mcm1957 commented 8 months ago

@agross THANKS for your PR