room clean doesn't work with 3.9.0

[Diginix]

Describe the bug
room clean doesn't work

To Reproduce
just set one of mihome-vacuum.0.rooms.*.roomClean to true when robot is charging in dock

Expected behavior
usually the robot starts to clean the choosen room every second setstate of the same roomClean state pushes this room to the queue. Although no cleaning is active.

Versions:

• Adapter version: 3.9.0
• JS-Controller version: 4.0.24
• Node version: 16.19.0
• vacuum cleaner: roborock.vacuum.m1s (fw 3.5.4_1370)

No log messages appear.

[dirkhe]

Please send debuglog, because it could be, that your robog does not except the repeat syntax, so perhaps i can find some info, if this feature accepted

[Diginix]

2023-01-06 10:10:09.316 - debug: mihome-vacuum.0 (15309) update_Map got new url:https://cnbj2.fds.api.xiaomi.com/robomap/ruby2/261288508/2?Expires=1672998009000&GalaxyAccessKeyId=5271733786445&Signature=QN3qdKsvjcgtDi8lyJk60yUY9kk=
2023-01-06 10:10:09.317 - debug: mihome-vacuum.0 (15309) update_Map got new expires:1672998009
2023-01-06 10:10:09.317 - debug: mihome-vacuum.0 (15309) update_Map got new time:1672996208
2023-01-06 10:10:10.121 - debug: mihome-vacuum.0 (15309) Receive <<< Helo <<< 21310020000000000f92f23c63b7e571ffffffffffffffffffffffffffffffff
2023-01-06 10:10:12.428 - debug: mihome-vacuum.0 (15309) command: roomClean parent: 277001004449
2023-01-06 10:10:12.433 - debug: mihome-vacuum.0 (15309) We are in onMessage:{"command":"cleanSegments","message":{"segments":[21],"channels":["mihome-vacuum.0.rooms.277001004449"]},"from":"system.adapter.mihome-vacuum.0","_id":88051417}
2023-01-06 10:10:12.434 - debug: mihome-vacuum.0 (15309) start Cleaning: 18 MObj: {"command":"cleanSegments","message":"21","from":"system.adapter.mihome-vacuum.0","_id":88051417,"segments":[21],"channels":["mihome-vacuum.0.rooms.277001004449"]}
2023-01-06 10:10:12.436 - info: mihome-vacuum.0 (15309) trigger cleaning segment 21
2023-01-06 10:10:12.436 - debug: mihome-vacuum.0 (15309) Message= {"id":74,"method":"app_segment_clean","params":[{"segments":[21],"repeat":1}]}
2023-01-06 10:10:12.454 - debug: mihome-vacuum.0 (15309) MIIO RECIVE: {"error":{"code":-10000,"message":"data for segment is not a number"},"id":74}
2023-01-06 10:10:12.461 - debug: mihome-vacuum.0 (15309) command: fan_power parent: control
2023-01-06 10:10:12.462 - debug: mihome-vacuum.0 (15309) Message= {"id":75,"method":"set_custom_mode","params":[103]}
2023-01-06 10:10:12.482 - debug: mihome-vacuum.0 (15309) MIIO RECIVE: {"result":["ok"],"id":75}
2023-01-06 10:10:18.607 - debug: mihome-vacuum.0 (15309) get params for stock Vacuum
2023-01-06 10:10:18.607 - debug: mihome-vacuum.0 (15309) Message= {"id":76,"method":"get_status"}
2023-01-06 10:10:18.624 - debug: mihome-vacuum.0 (15309) MIIO RECIVE: {"result":[{"msg_ver":1,"msg_seq":2249,"state":8,"battery":100,"clean_time":569,"clean_area":9900000,"error_code":0,"map_present":1,"in_cleaning":0,"in_returning":0,"in_fresh_state":1,"lab_status":1,"fan_power":103,"dnd_enabled":0,"map_status":3,"lock_status":0}],"id":76}
2023-01-06 10:10:18.625 - debug: mihome-vacuum.0 (15309) setGetStatus {"msg_ver":1,"msg_seq":2249,"state":8,"battery":100,"clean_time":569,"clean_area":9900000,"error_code":0,"map_present":true,"in_cleaning":false,"in_returning":0,"in_fresh_state":1,"lab_status":1,"fan_power":103,"dnd_enabled":false,"map_status":3,"lock_status":0,"error_text":"No error"}
2023-01-06 10:10:18.625 - debug: mihome-vacuum.0 (15309) Message= {"id":77,"method":"get_network_info"}
2023-01-06 10:10:18.639 - debug: mihome-vacuum.0 (15309) MIIO RECIVE: {"result":"unknown_method","id":77}
2023-01-06 10:10:18.639 - debug: mihome-vacuum.0 (15309) Message= {"id":78,"method":"get_sound_volume"}
2023-01-06 10:10:18.654 - debug: mihome-vacuum.0 (15309) MIIO RECIVE: {"result":[70],"id":78}
2023-01-06 10:10:18.655 - debug: mihome-vacuum.0 (15309) Message= {"id":79,"method":"get_carpet_mode"}
2023-01-06 10:10:18.671 - debug: mihome-vacuum.0 (15309) MIIO RECIVE: {"result":[{"enable":0,"current_integral":450,"current_high":500,"current_low":400,"stall_time":10}],"id":79}
2023-01-06 10:10:18.716 - info: mihome-vacuum.0 (15309) State value to set for "mihome-vacuum.0.control.carpet_mode" has to be type "switch" but received type "boolean" 
2023-01-06 10:10:20.136 - debug: mihome-vacuum.0 (15309) Receive <<< Helo <<< 21310020000000000f92f23c63b7e57bffffffffffffffffffffffffffffffff
2023-01-06 10:10:22.077 - info: mihome-vacuum.0 (15309) Got terminate signal TERMINATE_YOURSELF
2023-01-06 10:10:22.078 - error: mihome-vacuum.0 (15309) Socket Close
2023-01-06 10:10:22.079 - info: mihome-vacuum.0 (15309) terminating
2023-01-06 10:10:22.080 - debug: mihome-vacuum.0 (15309) Plugin sentry destroyed
2023-01-06 10:10:22.080 - info: mihome-vacuum.0 (15309) Terminated (ADAPTER_REQUESTED_TERMINATION): Without reason

[dirkhe]

Ok, your device will not support this, I will fix it and if I get this answer, I will send it in the old way and remove repeat Datapoints. I will also try to check thin on first clean, if the device will support this. Thank you for the log file.

[dirkhe]

PLease check, if it works now.

[dirkhe]

Could you also check, if you can repest set 2, once for a room and for a zone, if available?

[Diginix]

I will try as much as possible features with 3.9.2 this weekend.

[Diginix]

Goto, roomClean, map etc is working fine with 3.9.2. Not tested yet: repeated roomClean and spotClean. Thanks for the fix.

[Diginix]

spotClean and repeated roomClean (2) works as well with mit M1S.