iobroker-community-adapters / ioBroker.nuki-extended

Nuki Smart Lock - Keyless electronic door lock for smart access with your ioBroker
MIT License
29 stars 15 forks source link

node 18 - Bridge Api is broken #226

Closed Grothesk242 closed 2 years ago

Grothesk242 commented 2 years ago

Running node18 the adapter does throw these lines: nodeJS versions up to node17 do work with the same settings for the bridge API.

2022-04-20 22:42:39.640  - info: host.chet instance system.adapter.nuki-extended.0 started with pid 3156
2022-04-20 22:42:41.984  - info: nuki-extended.0 (3156) starting. Version 2.4.0 in /opt/iobroker/node_modules/iobroker.nuki-extended, node: v18.0.0, js-controller: 4.0.23
2022-04-20 22:42:43.255  - warn: nuki-extended.0 (3156) No bridges are sufficiently defined! Name, IP or token missing or all bridges deactivated!
2022-04-20 22:43:24.685  - warn: nuki-extended.0 (3156) Error triggering action via Nuki Bridge API: No Nuki Hex ID given!
2022-04-20 22:43:35.853  - warn: nuki-extended.0 (3156) Error triggering action via Nuki Bridge API: No Nuki Hex ID given!
2022-04-20 22:44:34.523  - info: host.chet stopInstance system.adapter.nuki-extended.0 (force=false, process=true)
2022-04-20 22:44:34.532  - info: nuki-extended.0 (3156) Got terminate signal TERMINATE_YOURSELF
2022-04-20 22:44:34.534  - info: nuki-extended.0 (3156) Adapter stopped und unloaded.
2022-04-20 22:44:34.536  - info: nuki-extended.0 (3156) terminating
2022-04-20 22:44:34.537  - info: nuki-extended.0 (3156) Terminated (ADAPTER_REQUESTED_TERMINATION): Without reason
2022-04-20 22:44:34.549  - info: host.chet stopInstance system.adapter.nuki-extended.0 send kill signal
2022-04-20 22:44:35.130  - info: host.chet instance system.adapter.nuki-extended.0 terminated with code 11 (ADAPTER_REQUESTED_TERMINATION)
2022-04-20 22:44:37.676  - info: host.chet instance system.adapter.nuki-extended.0 started with pid 3186
2022-04-20 22:44:40.003  - info: nuki-extended.0 (3186) starting. Version 2.4.0 in /opt/iobroker/node_modules/iobroker.nuki-extended, node: v18.0.0, js-controller: 4.0.23
2022-04-20 22:44:41.098  - warn: nuki-extended.0 (3186) No bridges are sufficiently defined! Name, IP or token missing or all bridges deactivated!
Grothesk242 commented 2 years ago

I think it may be related to changes in iface.family in Node.js 18: https://github.com/bnielsen1965/mdns-server/pull/8

Grothesk242 commented 2 years ago

Issue will be solved with patched upstream version 1.1.6 of node module 'ip' See commit https://github.com/jaiswarvipin/node-ip/commit/5d53c5a35d59f8c82ee56978973ce4e43285ae30

Grothesk242 commented 2 years ago

Please update dependencies for ip to 2.0.0.

Grothesk242 commented 2 years ago

Please update dependency for ip to 2.0.0.

https://github.com/indutny/node-ip

https://github.com/indutny/node-ip/issues/113

Grothesk242 commented 2 years ago

@Apollon77 Lieb guck... :-D

Apollon77 commented 2 years ago

So ip 1.1.6 is not enough??

Grothesk242 commented 2 years ago

Not sure. 2.0.0. has hints to 'node 18 compatibility' in the change logs.

Apollon77 commented 2 years ago

next verison

Grothesk242 commented 2 years ago

I confirm: v2.5.0 is up and running with vanilla nodeJS 18.2.0