search

iobroker-community-adapters / ioBroker.pvforecast

Forecast for your photovoltaic plant in ioBroker
Other
23 stars 13 forks source link

[Enhancement]: Damping factor for Forecast.solar #130

Closed coltc50 closed 6 months ago

coltc50 commented 6 months ago

I'm sure that

Used integration

forecast solar

The problem

I like to have the damping factor configured because my solar is shadded in the morning. Is there a way to add it?

iobroker.current.log (in debug mode!)

No response

Version of nodejs

18.19

Version of ioBroker js-controller

5.0.17

Version of adapter

2.9.1

github-actions[bot] commented 6 months ago

Thanks for reporting a new issue @coltc50!

  1. Please make sure your topic is not covered in the documentation
  2. Ensure that you use the latest beta version (not the current stable version): 2.9.1
  3. Please attach all necessary log files (in debug mode!), screenshots and other information to reproduce this issue

  4. Search for the issue topic in other/closed issues to avoid duplicates!

    Otherwise this issue will be closed.

coltc50 commented 6 months ago

I forked your github and hardcoded my needed damping factor to the script. Installed it from my forked github into iobroker and it works. Can be closed... but it would be nice if it can adjusted in the settings...

klein0r commented 6 months ago

but it would be nice if it can adjusted in the settings...

Since you are able to understand and modify the code: Please submit a PR

coltc50 commented 6 months ago

I think I understand the code but I search the index.html for the admin panel to add a new point... I don't find this page in github...

mcm1957 commented 6 months ago

Adapter uses jsonConfig. The config UI must be adapted at admin/jsonConfig.json

If you have any questions related to adapter development feel free to join our telegram channel. Invate links are available at https://www.iobroker.dev

coltc50 commented 6 months ago

Thanks for help... I added a pull request... Add it quick and dirty to pv tab.

coltc50 commented 6 months ago

Sorry, had no time to work on it before. See now it's added... Great and thanx for help...

mcm1957 commented 6 months ago

Well if it's added this issue could be closed? Couldnt it?