iobroker-community-adapters / ioBroker.tankerkoenig

Spritpreis Adapter für ioBroker
http://www.iobroker.net
MIT License
31 stars 13 forks source link

[Bug]: Cheapest Station Boolean true even if not cheapest #111

Closed Diginix closed 1 year ago

Diginix commented 1 year ago

Is there an existing issue for this?

Current Behavior

3 of 4 stations has price 1.699 and one has 1.719. All 4 stations has cheapest = true

What did you expect to happen?

No response

How to reproduce it (minimal and precise)

No response

Adapter version

3.3.2

Environment

- Node: 16.19.9
- npm: 8.19.3
- JS-Controller: 4.0.24
- Operating system: Ubuntu LTS

What browsers are you seeing the problem on?

No response

Screenshots & Log

image

xXBJXx commented 1 year ago

Check if tankerkoenig.0.stations.cheapest.e5.cheapest_stations also contains the station

Diginix commented 1 year ago

No this JSON contains only the 3 correct ones.

xXBJXx commented 1 year ago

Is the station closed or open?

Diginix commented 1 year ago

open

xXBJXx commented 1 year ago

ok i will look at it again

Diginix commented 1 year ago

All 4 are in the same city and has the same "conditions" atm. Only the boolean flag seams not to be toggled if another one becomes cheaper.

xXBJXx commented 1 year ago

I cannot reproduce the error, I have now created 7 stations and run the times a few hours, let the flag is set as well as the names in the tankerkoenig.0.stations.cheapest.e5.cheapest_stations. Was the state about have updated ⇨ image

Diginix commented 1 year ago

Also the update time was the same as for all other stations. At the moment the real cheapest station is flaged, all others not. I have 8 stations, 4 for 2 different cities. But this doesn't matter for the logic. Only the cheapest price over all should be flagged. No matter how much stations. I will have a look if it happens again. But I don't know what more I could provide for finding the cause. btw: I use E10, not E5

xXBJXx commented 1 year ago

btw: I use E10, not E5

Maybe you should have said that earlier because there is a bug because not the e10, but the e5 are displayed, I have had a written error in the variable. That could be the problem.

xXBJXx commented 1 year ago

I fix it in version 3.3.3

Diginix commented 1 year ago

Sorry, doesn't thought that the fuel type could matter. But good to hear that you found something related.

smartcuc commented 1 year ago

Cool. Having the same issue und good to hear, that there will be fix.

xXBJXx commented 1 year ago

Released in v3.3.3