search

ioc32 / openhrc

Open Household Router Contraption
Other
13 stars 4 forks source link

Moving 'install base packages' task to stage2 #5

Closed ioc32 closed 9 years ago

ioc32 commented 9 years ago

Currently we handle the installation of packages in stage1.

To my mind, it makes more sense to move it to stage2. This way, stage1 would only be run once, while the rest of the system configuration can be perfomed idempotently with stage2.

I'd also like to rename the task as 'install packages' and the var as 'pkgs', since there's no distinction between 'base' and 'user' packages (for now).

For the record, I came up with this when installing mtr, which I am planning to add to the default list of OpenHRC packages ;-)

saghul commented 9 years ago

Sounds good! Actually I was thinking about shrinking the packages list to the minimum, to make it (a tad) less opinionated ;-) On Apr 26, 2015 7:22 PM, "Malibu Carl" notifications@github.com wrote:

Currently we handle the installation of packages in stage1.

To my mind, it makes more sense to move it to stage2. This way, stage1 would only be run once, while the rest of the system configuration can be perfomed idempotently with stage2.

I'd also like to rename the task as 'install packages' and the var as 'pkgs', since there's no distinction between 'base' and 'user' packages (for now).

For the record, I came up with this when installing mtr, which I am planning to add to the default list of OpenHRC packages ;-)

— Reply to this email directly or view it on GitHub https://github.com/ioc32/openhrc/issues/5.

ioc32 commented 9 years ago

Oh, in that case, I don't mind splitting the base and user packages today.

Let's use base_pkgs in stage1 and user_pkgs in stage2.

ioc32 commented 9 years ago

If you are happy with my last commit, close the issue. Otherwise, amend and close :-)

saghul commented 9 years ago

Looking good!