iocave / customize-ui

UI Customization plugin for vscode
MIT License
527 stars 36 forks source link

Changing panel alignment bug in VS Code 1.64.2 with customize UI / monkey patch enabled #125

Open dmalyuta opened 2 years ago

dmalyuta commented 2 years ago

I am using VS Code 1.64.2-1644445741 on Ubuntu 20.04.3 and here is what happens when I try to use the new "Configure layout" feature: monkey-patch-fail

knopp commented 2 years ago

You don't need to restart, Just reloading the window (Developer: Reload Window) should fix this. This might be tricky to fix properly because customize-ui changes the layout in a way VSCode doesn't expect.

gee-forr commented 2 years ago

I have the same problem, but unfortunately, reloading the window or restarting VSCode doesn't fix the issue.

My layout is:

Tree on left, Activity Bar under tree, 2 Panes of editors, and vertical Terminal on right hand side as a side panel

That being said - I can get it kinda-working by: Right click on vertical terminal -> Move views to panel. Once I do this, the layout is mostly back to normal, except the status bar renders within vertical terminal's column, and not across the whole window like it used to. If I close the terminal, the rendering breaks again.

This all started when the VSCode team started to refactor the side-panel functionality in v1.64.

In the meantime, I'm downgrading to 1.63. Thanks for making VSCode's ugly UI better. I'd rather be on an old version of vscode, than not be able to use this extension.

Here's some screens of the problem:

When terminal is a side panel on the right

image

When terminal is a view on the right, and not part of the new side panel

Screenshot 2022-02-13 at 13 40 18

When terminal is a view on the right and is closed, and not part of the new side panel

NOTE This can be helped a little by disabling the Move statusbar under panel config option, which is ultimately not what I want.

Screenshot 2022-02-13 at 13 40 21

knopp commented 2 years ago

Do you have customizeUi.moveStatusbar set to true?

knopp commented 2 years ago

Nevermind, I can see your comment. moveStatusbar option will probably be difficult to get working with dnyamic layout configuration.

knopp commented 2 years ago

Btw. Can't you move views from panel to side panel instead? I don't know see what is the point of having panel on the right when there is already sidepanel. Can't you move terminal to sidepanel and move panel to bottom?

knopp commented 2 years ago

This is an example with panel moved to bottom (and hidden) and terminal moved to side panel. This way customize UI can work just fine.

Screenshot 2022-02-13 at 13 40 58
gee-forr commented 2 years ago

OMG Thank you!!!

This fixed it perfectly for me. Honestly, this whole Side Panel/View/Panel nonsense has been nothing but a confusing pain.

Can confirm, when I move everything from a view to the new side panel, and then move the view to the bottom and hide it, things work as normal again.

Thank you so much!

dzpt commented 2 years ago

@knopp anyway to move panel under both editor and panel? keep panel visible? since dragging Terminal only on the right gives ugly left borderless