Frameless title bar no longer working

[danrocha]

I believe the following settings combination are no longer working:

"window.titleBarStyle": "native",
"customizeUI.titleBar": "frameless",

VSCode Insiders (September 1.72)

Anyone else?

[knopp]

Is this with customize-ui 0.1.64?

[danrocha]

Yes. Updated 5 days ago.

[roycastro]

Hey @knopp, thanks for supporting this plugin. I'm also getting the described behavior with the following setup:

Customize UI: v0.1.64 Monkey Patch v0.1.19 Visual Studio Code: Version: 1.72.0-insider Commit: 333754f29b719f605904f072b13c054c2231b9bd Date: 2022-09-21T05:40:07.654Z Electron: 19.0.17 Chromium: 102.0.5005.167 Node.js: 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 21.4.0 Sandboxed: Yes

[knopp]

Sadly I can't reproduce this.

Can you post here content of /Users/<your-folder>/Library/Application Support/Code - Insiders/User/globalStorage/iocave.monkey-patch/modules/main.js ?

[roycastro]

Sure @knopp, here it's. main.js

require.config({
    paths: {
        "customize-ui" : "/Users/myuser/Library/Application Support/Code - Insiders/User/globalStorage/iocave.customize-ui/modules",
        "monkey-generated" : "/Users/myuser/Library/Application Support/Code - Insiders/User/globalStorage/iocave.monkey-patch/modules"
    }
});

define(["monkey-generated/entrypoint-main", "customize-ui/title-bar-main-process", "customize-ui/utils"], function (){});

[danrocha]

Here is it:

require.config({
    paths: {
        "customize-ui" : "/Users/danieldarocha/Library/Application Support/Code - Insiders/User/globalStorage/iocave.customize-ui/modules",
        "monkey-generated" : "/Users/danieldarocha/Library/Application Support/Code - Insiders/User/globalStorage/iocave.monkey-patch/modules"
    }
});

define(["monkey-generated/entrypoint-main", "customize-ui/title-bar-main-process", "customize-ui/utils"], function (){});

[knopp]

I was able to reproduce this after clean reinstall. I pushed updates for both customize-ui and monkey patch. It should work with latest stable (1.71.2), but insiders currently has a bug where the amd-loader is not used. I believe this is going to get fixed in vscode so I don't want to add additional workarounds in monkey-patch for that.

If you want to get customize-ui working with latests insiders you can try the following: Edit Visual Studio Code - Insiders.app/Contents/Resources/app/out/main.js and replace require_bootstrap_amd() with require('./bootstrap-amd').

[knopp]

Actually, I was reading the code wrong. This part works as expected. I have pushed monkey-patch@0.1.21 which should do the step automatically.

[danrocha]

I can confirm it is working now! Thank you @knopp