search

iocave / monkey-patch

Inject custom javascript into vscode
MIT License
154 stars 17 forks source link

Monkey Patch does not agree with recent insiders versions #19

Closed septsea closed 2 years ago

septsea commented 3 years ago

I use the latest VS Code Insiders. However, Monkey Patch does not seem to work. I specified what fonts I'd like to use, and I enabled Monkey Patch and Customize UI, but there's no change... image image

knopp commented 3 years ago

Please let me know if the problem persists after 0.1.50 gets live.

septsea commented 3 years ago

It works now. Thanks! image

septsea commented 3 years ago

I just updated VS Code Insiders, but the same thing happened again...

knopp commented 3 years ago

Can you check if this persists with 0.1.12?

septsea commented 3 years ago

@knopp Everything works pretty well! I cannot help wondering what on earth makes the extensions malfunction, by the way.

knopp commented 3 years ago

The extension heavily relies on vscode internals. So every time there is a refactor in vscode it can potentially break monkey-patch.

knopp commented 3 years ago

In general using customize-ui/monkey-patch with insiders is not a very good idea, since I can't always fix the issue immediately as it happens.

septsea commented 3 years ago

Well, I just like trying new things on my own PC. VS Code is more a toy than a text editor for me. If I did not know the existence of your two extensions, I would always have to replace some files manually—I also tried to write an extension to apply my changes automatically, but I failed. I appreciate your work very much. 😁

septsea commented 3 years ago

Excuse me. I am here to say that the extension does not work in the latest VSC-insiders! I sound like a tester who knows nothing about JavaScript. 🤣

septsea commented 3 years ago

Hey! Long time no see. The extension does not work again! Version: 1.58.0-insider.

knopp commented 3 years ago

Can you try with monkey patch 0.1.14 and customize-ui 0.1.54? They should be available soon. You will need to restart VScode and it should ask you to re-apply MonkeyPatch.

mixphix commented 3 years ago

Doesn't work for me on those versions (1.58.0-insider, MP 0.1.14, CUI 0.1.54) after disabling and reinstalling, and restarting VS Code several times.

knopp commented 3 years ago

I just tried upgrading 0.1.13 and 0.1.53 (which doesn't work) to 0.1.14 and 0.1.54 and it seems to work fine. Which platform are you on?

mixphix commented 3 years ago

I'm on Windows. I've tried disabling MP 0.1.14 before uninstalling, uninstalling without disabling, and nothing seems to work. Disabling without uninstalling either.

knopp commented 3 years ago

My bad. There is a problem with windows path separators I didn't expect. I'm working on it.

knopp commented 3 years ago

@bi-functor, can you let me know if 0.1.15 works for you once available? (should be in few minutes)

mixphix commented 3 years ago

Yeah, MP 0.1.15 works now! Thanks for the quick fix!

septsea commented 3 years ago

Good morning. Thank you so much! @knopp @bi-functor

rbadapanda commented 2 years ago

Please close this ticket if it is fixed.