iocave / monkey-patch

Inject custom javascript into vscode
MIT License
154 stars 17 forks source link

Fix path bug on Windows 10 #20

Closed twome closed 2 years ago

twome commented 3 years ago

No idea if this passes tests but this fixed #5 as per @EricPlayZ's suggestion .

ardittristan commented 3 years ago

fixes it for me

twome commented 2 years ago

Hi, any chance this could get another look? Eric's fix got a lot of likes; it's probably fair to say this bug is definitely worth fixing for the amount of people it affects. I fixed the path joining to use Node's path.join. It's been a while and I forgot this bug's still affecting me, which in turn breaks Customize UI, which in turn makes VSCode filled to the brim with ugly useless buttons, haha :) Thank you so much for this extension, btw; when it breaks I realise how utterly essential it is to make VSCode even remotely useable.

twome commented 2 years ago

Bump :)

twome commented 2 years ago

Thank you! <3