search

iocave / monkey-patch

Inject custom javascript into vscode
MIT License
154 stars 17 forks source link

fix: update bootstrap-amd for recent upstream changes #58

Closed forivall closed 1 year ago

forivall commented 1 year ago

Upstream changes:

https://github.com/microsoft/vscode/pull/161161 https://github.com/microsoft/vscode/pull/166686

This partly fixes https://github.com/iocave/monkey-patch/issues/56, https://github.com/iocave/monkey-patch/issues/34, https://github.com/iocave/monkey-patch/issues/55, and https://github.com/iocave/monkey-patch/issues/59 such that the UI should still appear after monkey-patch is installed.

Fixing customize-ui and other downstream monkey-patching extensions will require a patch in VSCodium for now (Which I did a proof of concept at https://github.com/VSCodium/vscodium/compare/master...forivall:vscodium:monkey-patch , which allows customize-ui to work) and further down the line, some cooperation with VSCode's core team, or reverse-source mapping to access private / protected methods.

knopp commented 1 year ago

Thanks. I'll do my best to test this tomorrow.

lehni commented 1 year ago

@knopp would love to see this fixed so we can start working with a patched VSCodium!

ccmvn commented 1 year ago

When will the fix be merged?

GJRobert commented 1 year ago

I have switched to VSCodium 1.74+ (now I'm using VSCodium 1.76.1), where a modified version of MonkeyPatch works (with Custom UI!). ☞ https://github.com/VSCodium/vscodium/issues/1390#issuecomment-1411187403 I have migrated most of my VS Code profile settings to VSCodium with ease. (tell me to post an English version of migration if needed)

MonkeyPatch + CustomUI is essential! Please keep it guys~