search

ioccc-src / mkiocccentry

Form an IOCCC entry as a compressed tarball file
Other
28 stars 5 forks source link

Fix make prep - resolves #851 #853

Closed xexyl closed 3 months ago

xexyl commented 3 months ago

Although a lot of really strange error messages occurred, first streams not being ready (fd_is_ready() returned false) and then once that was fixed (in part at least) many other weird seemingly unrelated errors occurred. The problem was with commit 4c8f0d567156e3e62b72c6e069bb8e36d834019e: by accident the "iocccsize_version" in the JSON files in jparse/test_jparse/test_JSON and test_ioccc/test_JSON was not updated. This caused the many different error messages which broke chkentry_test.sh which broke make prep.

The fd_is_ready() function now returns true if isatty(fd) as well. This appeared to solve the original problem of fd_is_read() returning false though this does not entirely make sense given that the files were actually files, not tty descriptors.

Updated CHANGES.md for these updates.

lcn2 commented 3 months ago

Thank you, @xexyl : make release and make prep now PASS well on macOS and RHEL 9 Linux.

xexyl commented 3 months ago

Thank you, @xexyl : make release and make prep now PASS well on macOS and RHEL 9 Linux.

I'm happy to help. It's a funny thing how when we look at error messages that are detailed sometimes we can get so into analysing them and tracing them that the real problem (that you likely already thought of .. I had) is ignored for a while. I'm just glad I had the thought to check what I wondered about earlier on and that it worked.