search

ioccc-src / temp-test-ioccc

Temporary test IOCCC web site that will go away
Creative Commons Attribution Share Alike 4.0 International
28 stars 6 forks source link

Fix stray and bogus file 'z' after make www #2304

Closed xexyl closed 3 weeks ago

xexyl commented 3 weeks ago

The problem is that bin/md2html.sh had the line:

    cp "$TMP_STRIPPED_MD" z

It did not use the file and it did not delete it either.

xexyl commented 3 weeks ago

Running make www updated the sitemap and the status.json and status.html files. I did not commit those as those were not updated by me. Perhaps you'd like to fix them or else tell me (for future reference) that they should be updated.

Off to do other things.

UPDATE 0

The sitemap update is the timestamp of every single file (it seems like). That can't be right?

lcn2 commented 3 weeks ago

That z file was a test file that should've been removed. We forgot to mark the debug code with an XXX so we didn't notice it until too late.

Thanks 🙏 for the catch, @xexyl

lcn2 commented 3 weeks ago

The sitemap update is the timestamp of every single file (it seems like). That can't be right?

As your modification file times will differ from our modification times, this will cause sitemap changes like what you see

We need to take the sitemap make action out of the www and quick_www actions.

UPDATE 0

Fixed in commit 60960e16500359911f43cb7527af3690b15d3394

UPDATE 1

As a result of processing this pull request, @xexyl, we passed the 5000th commit 🎉🥳

xexyl commented 3 weeks ago

That z file was a test file that should've been removed. We forgot to mark the debug code with an XXX so we didn't notice it until too late.

Thanks 🙏 for the catch, @xexyl

At first I thought I had left the file there but after deleting it it happened again each time so I decided to look into it.

xexyl commented 3 weeks ago

The sitemap update is the timestamp of every single file (it seems like). That can't be right?

As your modification file times will differ from our modification times, this will cause sitemap changes like what you see

We need to take the sitemap make action out of the www and quick_www actions.

Okay but the real point was that every single file seemed to have an updated timestamp. I don't know why and I don't know if it's a problem but thought I'd bring it up. Hopefully this is more clear now.

UPDATE 0

Fixed in commit 60960e16500359911f43cb7527af3690b15d3394

Thank you!

UPDATE 1

As a result of processing this pull request, @xexyl, we passed the 5000th commit 🎉🥳

Nice!