search

iocost-benchmark / iocost-benchmarks-ci

Apache License 2.0
1 stars 3 forks source link

Autoreject duplicate results #24

Open obbardc opened 1 month ago

obbardc commented 1 month ago

For pull requests which have the same results (e.g UUID in the filename) as existing results in the database, we should close PRs and issues.

@htejun is UUID in filename a suitable collision detection method?

In this case, rejection really means closing of issue, PR , deletion of files in bucket & branches.

Possibly there could be a nightly CI run which triggers this.

htejun commented 1 month ago

I don't know where there UUID in the filename is coming from. I think it might make sense to add a signature in the result json file itself for reliable detection - ie. let the json file carry its own signature as its ID. What do you think?

obbardc commented 1 month ago

Looks like that md5sum is currently the md5sum of the uploaded data. we can initially reject on that, before even processing the result.