Webdav save

[Jenselme]

Enhancements

These are proposed enhancements. Feel free to comment them.

• [x] Provide help on each fields
• [ ] Add possibility to fold the webdav connection fields
• [x] Improve message when loading file
• [x] Add a path field
• [x] Translate the fields
• [x] If the user check don't save after the drawing was automatically saved once, we should delete it from our servers and remove the mention of the file in the permalink
• [x] Translate error messages
• [ ] Allow the user to load automatically (ask for username and password if necessary) a KML imported this way
• [ ] Allow the user to import a KML from a webdav server with the KML import tool
• [X] How it works on mobile/small screen Drawing is not available on mobile.
• [ ] Modify the KML from the geoadmin interface and somewhere else. I guess one file should erase the other. Should we add conflict resolution?
• [X] Remember previously typed urls in Firefox
• [ ] Remember previously typed urls in chrome
• [x] Ask for confirmation before overriding a file
• [x] Improve display of user messages: ours and Swisstopo's aren't handled the same way.
• [x] Reuse drawing layer on import

  Points that require input

  1. General layout of the functionality. I tried to place the elements logically but you have more experience in this domain than I have. Moreover, I currently display webdav related messages under the webdav connection block. I don't know if it would be better to place them all with the "saving" messages.
  2. Should the drawing be loaded from webdav server only from the KML import tool? I think not: in my opinion it makes sense to be able to load KML from both draw tools and KML import:
     • I want to draw
     • If I forgot to load it before, I can load it here
     • Can enter my credentials only once
  3. Should the filename/filepath be entered in another input field? Currently, the user must provide the full URL of the file in the URL field and not just the webdav endpoint. I think it can be disturbing for people who are familiar with webdav. On the other hand, that will make quite a lot of fields.
  4. Should I add a button Create to create an empty file. It is not necessary as the file will be created if it doesn't exist but it may be more obvious and clear than an explanation that the file will be created automatically.
  5. Should we add a way to browse files present on webdav server? Only KMLs? Problem: certainly long to do correctly (unless there is already an angular plugin for that).

[tigerfoot]

Just some remarks :

• The choice (radio button) is not checked when use on a tablet and index.html
• The choice (radio button) doesn't show the webdav info part when you have choose it previously close firefox and reopen
• Options without authentification : doesn't seems to work well with apache2 and php-fpm at least options with authentification work. (I've not checked deeply the code)

Globally : The whole functionality should be optional (shown or not) and we also need to provide a global external webdav. This could be used by customer that host the geoportail on our infrastructure, but want to have the drawings save on their own webdav with a unique global login)

About 1) It will unclutter the interface if we can have a dedicated webdav dialog. This popup show once the choice of own webdav is made Propose the url endpoint, a file selector (if use the button is load), if a newfile name is choosed (button is create). Once every is ready, just close the popup. webdav endpoint, username, password, and probably last file used should be stored (clean button) and automatically restored.

As the sentences are too long I would like to propose something like 3 radio img No save = server icon X red crossed Server = server icon Own Server = server + personna Make all of them with a tooltips explaining the choice. By default a user has nothing to read and he ready to draw.

[Jenselme]

As a reminder, the functional tests associated with this:

Requirements: you must be able to connect to a webdav server with a username and a password. On this server you must have access to 2 KMLs and another file.

To perform these tests, you must be in drawing mode and select "Save automatically on custom server".

File load

1. No url
   • Try to load a KML without a URL.
   • Result: a message asking for a URL must be displayed.
2. Wrong file name
   • Enter the correct URL.
   • Enter your credentials
   • Specify a wrong file name.
   • Result: a message saying the file cannot be found must be displayed.
3. Wrong credentials
   • Enter the correct URL.
   • Enter the correct filename.
   • Enter either the wrong username or the wrong password.
   • Result: a message saying that you are not authorized to load the KML must be displayed.
4. Wrong file type
   • Enter the correct URL.
   • Enter the path to a non KML file
   • Enter the correct credentials
   • Result: an alert must open saying that this file is not a valid KML.
5. Correct
   • Enter all fields correctly.
   • Result: the KML must be displayed.

File save

1. Existing
   • Enter all fields correctly
   • Start drawing
   • Result: a prompt appears asking if you really want to override this file. If you confirm, the KML will be overridden, if you cancel it won't be saved.
2. Creating
   • Enter all fields correctly
   • Enter the name of a new KML
   • Start drawing
   • Result: the KML must be created
3. Changing name
   • Enter all fields correctly
   • Load an existing KML
   • Change the name of the KML to your other file
   • Draw
   • Result: a prompt appears asking if you really want to override this file. If you confirm, the KML will be overridden, if you cancel, it won't be saved.

File delete

1. Features
   • Enter all fields correctly
   • Load a KML
   • Delete part of the drawing
   • Result: the KML must be updated
2. File
   • Enter all fields correctly
   • Load a KML
   • Go More > Delete all features
   • Result: the KML must be deleted