search

iodepo / odis-arch

Development of the Ocean Data and Information System (ODIS) architecture
https://book.oceaninfohub.org/
27 stars 16 forks source link

[TYPOS][persona.md] #205

Closed fcarvalhopacheco closed 1 year ago

fcarvalhopacheco commented 1 year ago

Hi @jmckenna, @pbuttigieg

Let me know if this is fine

Issue

Just found some typos on https://book.oceaninfohub.org/personas/persona.html#about

file: book/personas/persona.md

Solution

deisng --> design potenial --> potential

jmckenna commented 1 year ago

Thanks for this @fcarvalhopacheco, much appreciated.

But it looks like your schema-dev-fp branch was a fork of master, when in fact you should have the schema-dev instead (meaning: your fork contains master, not schema-dev changes). You must first make sure that your fork is on the schema-dev branch, then edit the file persona.md (inside the schema-dev branch), and then when you are ready, create a pull request into iodepo/schema-dev. (I'm sorry for the confusing steps ha). Does this make sense?

If you are doing this through the commandline (git) I can paste the steps here. Let me know. (the important part is that you do a git checkout -b schema-dev after you have the master branch locally).

(to do this I think we should close this pull request, and then you can create a new pull request, with your schema-dev changes locally, into the remote schema-dev branch)

Clear as mud? ha. Let me know if I can help.

jmckenna commented 1 year ago

(if you are just using your browser for edits, you can do this inside your fork's schema-dev branch at https://github.com/fcarvalhopacheco/odis-arch/blob/schema-dev/book/personas/persona.md )