iodepo / odis-arch

Development of the Ocean Data and Information System (ODIS) architecture
https://book.oceaninfohub.org/
26 stars 16 forks source link

Fix lat,lon ordering and point separation in polygon examples #364

Closed marksparkza closed 7 months ago

marksparkza commented 7 months ago

Examples of polygon have been incorrectly formatted as "lon lat" pairs separated by commas. According to schema.org's definition of GeoShape, point pairs should be formatted either as "lat lon" or "lat,lon", and points should be separated by whitespace, not commas.

jmckenna commented 7 months ago

@marksparkza thanks for the coordinate changes. I wonder about your proposed no space after the comma, as I see other examples with a space after the comma.

marksparkza commented 7 months ago

I suspect that JSON-LD processors may be lenient in this regard - i.e. allow either space or no space after the comma. I am essentially following the schema.org recommendation of "Either whitespace or comma" as lat-lon separator. I opted for the comma because I think (my perception, ymmv) that it is easier to visually pick points out of a series if each lat-lon pair is joined with a comma.

jmckenna commented 7 months ago

@marksparkza I agree with your thoughts on this, and reasoning. I am +1 for these changes.

jmckenna commented 7 months ago

@marksparkza thanks very much for your keen eye on this, it is very much appreciated. Merging...

jmckenna commented 7 months ago

@marksparkza oh I just noticed (we recently changed to doing all updates into master branch). Can you change this to master instead?

marksparkza commented 7 months ago

I've rebased onto master; closing this PR and will open a new one