iodepo / odis-arch

Development of the Ocean Data and Information System (ODIS) architecture
https://book.odis.org/
31 stars 18 forks source link

Person/nationality #469

Closed smrgeoinfo closed 3 weeks ago

smrgeoinfo commented 4 weeks ago

at https://book.odis.org/thematics/expinst/index.html#details-nationality Example at uses 'DefinedTerm' to associate with name from a vocabulary, but this throws and error in Schema.org validator. Would it make more sense to use nationality/Country/identifier:

{
    "@context": {
        "@vocab": "https://schema.org/"
    },
    "@id": "https://example.org/permanentUrlToThisJsonDoc",
    "@type": "Person",
    "nationality": [
        {
            "@type": "Country",
            "name": "Fiji",
             "identifier":
                     {  "@type": "PropertyValue",
                        "name": "Fiji",
                        "value": "FJ",
                        "propertyID": ["https://unece.org/trade/cefact/unlocode-code-list-country-and-territory","ISO 3166-1:2020"]            
                    }    
           }
      ]  }

this validates at https://validator.schema.org/

pbuttigieg commented 4 weeks ago

Good catch, thanks - the value space for nationality is limited to Country

@jmckenna could you update the book, scanning for all uses of nationality?

Please note the minor correction below

{ 
  "@context": { 
    "@vocab": "https://schema.org/"
  }, 
  "@id": "https://example.org/permanentUrlToThisJsonDoc", 
  "@type": "Person",
  "nationality": {
    "@type": "Country", 
    "name": "Fiji", 
    "identifier": {
      "@type": "PropertyValue", 
      "name": "ISO 3166-1 alpha-2 code", 
      "value": "FJ", 
      "propertyID": [
        "https://unece.org/trade/cefact/unlocode-code-list-country-and-territory",
        "ISO 3166-1:2020"
      ]
    } 
  }
}
jmckenna commented 3 weeks ago

Fixed through https://github.com/iodepo/odis-in/commit/2b9b13ac4eccafa97a3c1983b52471f773254e9c

The changes are now visible in the Book at https://book.odis.org/thematics/expinst/index.html#details-nationality

thanks @smrgeoinfo