UNSD Methodology CSV included multiple time

iodepo / oih-ui

source code for the Ocean InfoHub (OIH) website

https://oceaninfohub.org/

MIT License

5 stars 4 forks source link

UNSD Methodology CSV included multiple time #6

Closed arnounesco closed 1 year ago

arnounesco commented 2 years ago

the UNSD Methodology CSV file is included in both the indexer and the regions (with different filenames), this will lead to problems in the future whenever the list is update and not both files are updated. Should only be one file.

jmckenna commented 2 years ago

I wonder if we should switch to using a call to the UNSD API, using the /api/Country endpoint, instead of maintaining a separate CSV file, such as:

in your browser: https://unstats.un.org/unsd/amaapi/api/Country?countriesOnly=true

commandline:

curl -X 'GET' \
'https://unstats.un.org/unsd/amaapi/api/Country?countriesOnly=true' \
-H 'accept: */*'

see the docs at https://unstats.un.org/unsd/amaapi/swagger/index.html

jmckenna commented 2 years ago

At the minimum we should remove the spaces in this filename (it's disaster accessing this file on different platforms, because of the spaces).

pbuttigieg commented 1 year ago

Is this closed ?

jmckenna commented 1 year ago

@pbuttigieg fixed now, see details in https://github.com/iodepo/oih-ui/pull/77

The UNSD API is used instead (a single copy of the CSV is stored only for reference now, in the /regions/unsd-data/ folder )