search

iodepo / oih-ui

source code for the Ocean InfoHub (OIH) website
https://oceaninfohub.org/
MIT License
5 stars 4 forks source link

Implement the React internationalisation package with defined language at least 4 UN languages (EN, FR, ES, RU) #96

Open emarzini opened 9 months ago

jmckenna commented 9 months ago

@Hiidees @emarzini nice work on the first draft.

One point is that I really like how Pull Requests send automatic notices (through email and also Slack), but note that since your commit was done directly into a branch, without a Pull Request, no notices were sent out. Can I kindly request that all future changes are done first through a Pull Request (even if the Pull Request just stays open for a few minutes before your click the Merge green button), so that way we are all notified automagically of each potential change.

We can discuss this at our next meeting.

thanks,

jmckenna commented 9 months ago

Or maybe you plan to do a Pull Request later when that branch is ready? Yes that does make more sense :)

Anyway, just sharing my thoughts. Thanks for these excellent recent changes.

emarzini commented 9 months ago

Ok @jmckenna. We can discuss it in the next meeting. Our idea was to push something but not ready to be merged. We want discuss with all of you, also because the new UI will change a bit the way to implement the functionality in this issue. So, our intention was to not create a PR because the functionality is not ready yet

jmckenna commented 9 months ago

@emarzini thanks, yes I agree with your logic, so no need to change anything in your process. thanks again.