search

iodide-project / iodide-examples

example Iodide notebooks
27 stars 15 forks source link

DOM Manipulation Example #15

Closed djbarnwal closed 6 years ago

djbarnwal commented 6 years ago

This example notebook introduces the user to DOM and its manipulation in Iodide. An effort towards Issue #2. Looking forward to suggestions and review in order to make this better.

bcolloran commented 6 years ago

@hamilton -- to facilitate your review of @djbarnwal's NB, you can use the ?url= trick to load the NB without pulling iodide-examples. here's the link for you:

https://iodide-project.github.io/master/?url=https://raw.githubusercontent.com/djbarnwal/iodide-examples/64fa12b95015709801509fbfa10514c96b80544c/introduction-to-dom-and-its-manipulation.html

djbarnwal commented 6 years ago

@bcolloran Thanks a lot for reviewing and pointing out the errors. I would be careful with the grammar from now on and make sure I recheck my NB once in a while for typos. I do have Grammarly installed as an extension but unfortunately, it somehow doesn't work for Iodide cells. I would fix the errors and push the changes soon :-)

djbarnwal commented 6 years ago

@bcolloran I have corrected the typos and have added more explanation to the notebook. Do you have any more suggestions?

bcolloran commented 6 years ago

@djbarnwal sorry it's taken so long to get back to this notebook. It's very much improved by the addition of some more explanation, great work!

I notice one small detail: the transitions on your final bar plot at the very bottom always seem to set the bars to zero rather than transitioning from the initial bar height directly to the final bar height. That would be a nice little tweak to make, but it's pretty minor, so I'm going to go ahead and merge this at this point.