ioerror / blockfinder

Blockfinder enumerates network information for countries
http://github.com/ioerror/blockfinder
Other
127 stars 46 forks source link

Imported LIR country information may contain comments #51

Closed kloesing closed 9 years ago

kloesing commented 11 years ago

I found that 2043 of the 3868287 LIR entries (0.05%) contain more than just a country code:

sqlite> SELECT COUNT(*), country_code FROM assignments WHERE source_type = 'lir' AND country_code LIKE '%#%' GROUP BY country_code HAVING COUNT(*) > 2 ORDER BY COUNT(*) DESC;
1766|EU # Country is really world wide
171|EU # country is really somewhere in African Region
12|DE #AT # IT
6|EU #Country is really world wide
6|FR # GF # GP # MQ # RE
5|GB # AT BE DK FR DE IT NL PL PT RO ES SE
5|SE # FI NO DK
4|RU # AM AZ BY BA BG GE KZ KG LV LT MK MD PL RO TJ TM UA UZ YU
4|TR # DE # NL # FR
3|BE # DE GB LU NL
3|DE # IE
3|GB # US
3|GB #DE FR

Two thoughts:

  1. Are there similar data sources from other registries than RIPE? If RIPE says the country is really world wide or in African Region, maybe other registries have better information.
  2. Should we cut off parsed country lines at the first # and only import the entry if what remains is a two-letter code?
ioerror commented 11 years ago

Re: 1) Yes, if RIPE says it is in Asia, we should look at APNIC or whatever LIR/RIR that governs that area.

Re: 2) Probably, yes.

d1b commented 11 years ago
  1. last time I looked for similar data sources from registries other than RIPE I couldn't find any (maybe I wasn't looking in the right places ?)
  2. I agree with @ioerror . Also it seems like the some of the comments provide useful information (e.g. EU # Country is really world wide) that we could use in blockfinder ( or simply display?).
kloesing commented 11 years ago

Just saying that I won't be able to hack or comment on this for a while. Sorry.

d1b commented 10 years ago

@ioerror we can close this when we merge #74.

xiongchiamiov commented 10 years ago

It should be closed automatically when the pull is merged. Makes life easier! :)