search

ioerror / torbirdy

Torbutton for Thunderbird and related *bird forks
BSD 2-Clause "Simplified" License
84 stars 20 forks source link

helo_argument IP should be encapsulated in []'s #27

Closed u451f closed 8 years ago

u451f commented 8 years ago

This is a patch proposed by Chris Knadle chris.knadle@coredump.us to make torbirdy compliant with RFC 5821 §4.1.3. Also see Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=812115

Please also have a look at this bug which treats of a related issue: https://trac.torproject.org/projects/tor/ticket/13006

I did test it only on a Debian Jessie system, it works as expected. But I did not verify if this causes any leaks. Thus, before merging, please verify that this patch is indeed applicable and correct.

u451f commented 8 years ago

Submitting a new pull request because I made a mistake in the email of the original author. See https://github.com/ioerror/torbirdy/pull/28 sorry for the noise.