ioet / ioet-website-v2

IOET website
MIT License
0 stars 0 forks source link

Contentful type Navigation Link cannot link to a URI #26

Open ralden opened 4 years ago

ralden commented 4 years ago

Contentful type Navigation Link used to link to either a contentful reference, or a URI. We need both; either a single Navigation Link which can point to one type or another; or we need two Contentful types such as:

Navigation.Contentful and Navigation.URI

Also there is no ability to label the link with an image. Perhaps this is another type?

Wason1797 commented 4 years ago

The following components are only intended to be used in a navbar, inside the scope of a header or footer.

Navigation Link is only intended to link contentful references. Image Link is used to link contentful references with an image Image URL is used to link external URLs with an image

There is not a need to have a navigation Navigation Link to an external web page. If you want to include external links this should be handled on another component. Right now you can link external resources through the rich text component.