Quota argument does not work properly

ioi / isolate

Sandbox for securely executing untrusted programs

Other

1.05k stars 157 forks source link

Quota argument does not work properly #67

Closed horacekj closed 5 years ago

horacekj commented 5 years ago

isolate ... -q100,100 ... produces

Invalid numeric parameter: 100,100

This is probably due to the the fact that variable optarg points to 100,100 when calling opt_uint at line 1036.

gollux commented 5 years ago

Ah, this one is a victim of switching to strict parsing of numbers. Will fix in a minute.

simonlindholm commented 5 years ago

I think the fix for this was buggy: it first does *sep++ = 0; to overwrite the comma, then later inode_quota = opt_uint(sep+1);, skipping the first digit.

gollux commented 5 years ago

Sorry, it should be right now. Released 1.8.1 with a fix.