search

ioi / isolate

Sandbox for securely executing untrusted programs
Other
1.05k stars 157 forks source link

Increase the maximum number of open files to 4096 #97

Closed Neloop closed 2 years ago

Neloop commented 3 years ago

Hi, we came across the same problem as #85 when executing groovy runtime. Open files limit of 64 is just too low, consider please my change to 4096. It might seem high, but I think it is high enough to not interfere with sandboxed program and low enough to not cause any real problems on host machine. Thanks!

pppepito86 commented 3 years ago

Hi, I hit similar problem when trying to build native binary from java program using graalvm and native-image. I would be happy with the proposed increase, but I think a better solution would be to make this configurable. What do you think about extracting a property? Best Regards, Petar

gollux commented 3 years ago

What do you mean by a property?

pppepito86 commented 3 years ago

Command line option like --open-files=1000.

gollux commented 2 years ago

I made the limit configurable.

Neloop commented 2 years ago

Thank you