search

iokiwi / moneyapp

Parsing OFX files for personal budgeting and financial insights
Mozilla Public License 2.0
3 stars 2 forks source link

Export JSON implementation from client-side. #40

Closed abhinna1 closed 11 months ago

abhinna1 commented 11 months ago

Implemented JSON export in recurring_expenses. Issue

iokiwi commented 11 months ago

Thanks for your contribution! I'll try test and review it later today.

In earnest I had imagined this would be implemented server-side or at the very least the data would be requested from the server rather than assembled from the DOM.

I wondered if you could tell me a bit about your approach?

Do you see any advantages or disadvantages of doing it server-side vs client side?

abhinna1 commented 11 months ago

Surely, it could be implemented from the server side as well, but following the client-side approach, in my opinion would reduce some load on the server and the need to fetch the data from the database again and again. In the client-side approach, the data is simply downloaded from the table in the DOM. Whilst the server-side implementation would hit the database every single time we try to export it, unless we use a cache or a temporary in-memory database such as Redis. However, for now, I don't think it would be an issue to implement it on the server-side either.

iokiwi commented 11 months ago

Hey @abhinna1, just dropping in to see if you need a hand with anything or have any questions.

abhinna1 commented 11 months ago

Hi @iokiwi , sorry it's been taking a while. I'll hopefully get it done by tomorrow :smile:

iokiwi commented 11 months ago

Hi @iokiwi , sorry it's been taking a while. I'll hopefully get it done by tomorrow 😄

Absolutely no worries! I really was just reaching out to see if you needed a hand. Take all the time you need 😊

iokiwi commented 11 months ago

Thanks for your contribution! Your backend implementation has been merged. We'll close this PR