search

iommirocks / iommi

Your first pick for a django power cord
http://iommi.rocks
BSD 3-Clause "New" or "Revised" License
803 stars 51 forks source link

preserving filters from other table filters and sorting #496

Closed berycz closed 11 months ago

berycz commented 11 months ago

I moved the code from updateURL to queryPopulate, because it's not used anywhere else and it would need a new parameter (probably form), so it would be also inconsistent with the old iommi_update_URL. So now both iommi_update_URL and updateURL are deprecated. I would still leave them for some time, just to be sure.

And please if you can test it first before merging? The main problem in steps was:

  1. you sort a table
  2. you filter by something -> order got removed from the URL query string and thus the table wasn't in the right order anymore
    • also if you had multiple tables on a page, one filter would remove other filters from the URL query string
berycz commented 11 months ago

One thing I've just noticed - it also preserves the page, is that desired or not?

boxed commented 11 months ago

I've noticed that too sometimes and I think it's probably not a good idea...