iommirocks / iommi

Your first pick for a django power cord
http://iommi.rocks
BSD 3-Clause "New" or "Revised" License
658 stars 45 forks source link

table.Column.boolean check mark #508

Closed berycz closed 5 months ago

berycz commented 5 months ago

You use the font-awesome check icon in table.Column.boolean @with_defaults

cell__format=lambda value, **_: mark_safe('<i class="fa fa-check" title="Yes"></i>') if value else '',

I believe it might be better to get rid of the dependency and maybe use any of the utf-8 characters ✔ ✅ ✔ ☑ . And use the fa-check only in style_font_awesome_4.py

Column__shortcuts__boolean__cell__format=lambda value, **_: mark_safe('<i class="fa fa-check" title="Yes"></i>') if value else ''

Then in style_bootstrap_icons.py I'd probably use the bi-check-lg with fs-3

Column__shortcuts__boolean__cell__format=lambda value, **_: mark_safe('<i class="bi bi-check-lg fs-3"></i>') if value else ''
boxed commented 5 months ago

Agreed