search

ioncodes / idacode

An integration for IDA and VS Code which connects both to easily execute and debug IDAPython scripts.
725 stars 77 forks source link

Save files on execution with a config setting #9

Closed Plutoberth closed 4 years ago

Plutoberth commented 4 years ago

When running or debugging scripts in vscode, all open dirty editors are automatically saved. I added this functionality as a config option ("IDACode.saveOnExecute") that is enabled by default.

ioncodes commented 4 years ago

Thanks for the PR, I'll check this out ASAP!

ioncodes commented 4 years ago

This PR contains an async issue. The file gets saved but IDA has already executed the script by the time VS Code saves the file. On another execution it then successfully executes the script. I fixed that locally by calling the send function in the .then promise handler. I'll push to the PR and merge it in a bit! Thanks for implementing this feature!

Plutoberth commented 4 years ago

This PR contains an async issue. The file gets saved but IDA has already executed the script by the time VS Code saves the file. On another execution it then successfully executes the script. I fixed that locally by calling the send function in the .then promise handler. I'll push to the PR and merge it in a bit! Thanks for implementing this feature!

My bad, I barely use js\ts and I misread some documentation about .then. Thanks for this awesome plugin!

ioncodes commented 4 years ago

I'm glad you like the plugin!