search

iondrimba / react-calculator

:triangular_ruler: PWA React + Redux Calculator
https://calculator.iondrimbafilho.me/
69 stars 21 forks source link

Multiple themes using prefers-color-scheme #173

Open smebberson opened 5 years ago

smebberson commented 5 years ago

Have you considered offering a light and dark theme and automatically setting them based on the new prefers-color-scheme?

Would you be interested in a PR for this?

iondrimba commented 5 years ago

No I haven't considered it. Do you think by looking at the code base, that it would be easy to implement? Can you send me a simple sketch of how it would look?

smebberson commented 5 years ago

Your app looks entirely SASS based. Is that correct?

If so, I think it should be fairly simple if we follow something along the lines of https://medium.com/@dmitriy.borodiy/easy-color-theming-with-scss-bc38fd5734d1.

If you're half interested in this idea, I'll try and find some time to put together a quick example.

iondrimba commented 5 years ago

You are right about Sass. I'm interest in this idea @smebberson 👍