Open Athroniaeth opened 8 months ago
Attention: 73 lines
in your changes are missing coverage. Please review.
Comparison is base (
728752d
) 62.00% compared to head (60f79f5
) 62.36%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@cclauss does codecov's message require me to change something? his warning and message seem to be off the mark to me
Ignore the codeccov stuff, I'll fix it soon (the current config has bitrot).
I am not a fan of changing all those cached_properties. Is there no other way to help pycharm's code intel?
I am not a fan of changing all those cached_properties. Is there no other way to help pycharm's code intel?
I agree with you, I tried to do it without changing the "cached_properties" for fear of breaking the code/unit test but I couldn't find anything else. I don't think I'll try any other modifications.
Problem
It's been almost since I started python programming that I started using pytest. I use pytest-benchmark which I find easy to use and very practical. The only problem I was having trouble figuring out how to make changes to the stats (or just get the stats) and finding the imports for typing when I was a beginner. And this is also the case for novice work colleagues.
Objectives
When I am on PyCharm for example, the objective would be that
Result of my PR :
I realized during development that if I wanted a typing on "Stats" and its attributes (only for setter, if i don't make it, pycharm set hightlight because the attribtues can't be modified), I had to replace the cached_property because it prevents the implementation of an attributes.setter because Python considers that it is on this decorator that he must apply the setter and not the attribute. So I replaced the decorator with a system of cache work with a dictionnary
I was not able to launch toxin without error even before made a modification, but the unit tests did not change between the version I pulled and the version I made.
“Acceptance” tests have been created in “tests/test_acceptance.py”