search

ionelmc / python-manhole

Debugging manhole for python applications.
https://pypi.python.org/pypi/manhole
BSD 2-Clause "Simplified" License
374 stars 24 forks source link

Remove unneeded signal mask in connection thread #24

Closed nirs closed 10 years ago

nirs commented 10 years ago

Threads inherit the signal mask from the parent thread. There is no need to set the signal mask again.

A new test ensures that build will fail if this does not work as documented on some platform.

nirs commented 10 years ago

The relevant tests pass. All tox targets including coveralls seems to be broken, and test_daemon_connection seems unstable.

ionelmc commented 10 years ago

Hmmm, interesting. Very good catch.

ionelmc commented 10 years ago

Seems github doesn't detect rebases. It's in master now