search

ionelmc / python-tblib

Serialization library for Exceptions and Tracebacks.
BSD 2-Clause "Simplified" License
165 stars 33 forks source link

Test failures with Python 3.7 #36

Closed QuLogic closed 5 years ago

QuLogic commented 6 years ago

We are rebuilding everything against Python 3.7 in Fedora, and it looks like tblib is failing there:

=================================== FAILURES ===================================
_____________________________ [doctest] README.rst _____________________________
155     ...
156     >>> len(s3) > 1
157     True
158 
159 Unpickling
160 ~~~~~~~~~~
161 
162 ::
163 
164     >>> pickle.loads(s1)
Expected:
    (<...Exception'>, Exception('fail',), <traceback object at ...>)
Got:
    (<class 'Exception'>, Exception('fail'), <traceback object at 0x7f89feecf748>)
/builddir/build/BUILD/tblib-1.3.2/README.rst:164: DocTestFailure

It looks like maybe the comma in Exception('fail',) is removed now.

QuLogic commented 6 years ago

I've applied this patch to get it to pass for the time being.

QuLogic commented 5 years ago

Ping? We're starting to look at 3.8 already.

ionelmc commented 5 years ago

@QuLogic will kick some CI today to see how it goes.

ionelmc commented 5 years ago

Patch included in d4886fb.

ionelmc commented 5 years ago

Released v1.4.0.